From 3e0f8eed1f22f123020ec2137bbdbf9f522255ef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89tienne=20Barri=C3=A9?= Date: Tue, 19 Dec 2023 11:26:51 +0100 Subject: [PATCH 1/4] Remove warnings on CI failures without a screenshot --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e7d59d68..c4c3e5a9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -52,3 +52,4 @@ jobs: with: name: screenshots path: test/dummy/tmp/screenshots + if-no-files-found: ignore From e86ee8497b4a591148a559fb6eb85416a687f35e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89tienne=20Barri=C3=A9?= Date: Tue, 19 Dec 2023 12:01:17 +0100 Subject: [PATCH 2/4] Remove errors for duplicate artifacts --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c4c3e5a9..d61585de 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -50,6 +50,6 @@ jobs: uses: actions/upload-artifact@v4 if: failure() with: - name: screenshots + name: screenshots-${{ strategy.job-index }} path: test/dummy/tmp/screenshots if-no-files-found: ignore From 2ee626ab6a353d3f2757392938287cd58672f045 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89tienne=20Barri=C3=A9?= Date: Tue, 19 Dec 2023 14:21:20 +0100 Subject: [PATCH 3/4] Add a timeout for CI jobs --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d61585de..74f073a6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -6,6 +6,7 @@ jobs: build: runs-on: ubuntu-latest name: Ruby ${{ matrix.ruby }} / ${{ matrix.gemfile }} / ${{ matrix.database }} + timeout-minutes: 5 strategy: fail-fast: false matrix: From 5ce5e592da7f0135ebdb51346e6f6325c808cd6a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89tienne=20Barri=C3=A9?= Date: Tue, 19 Dec 2023 14:26:16 +0100 Subject: [PATCH 4/4] Add a bin/setup --- .github/CONTRIBUTING.md | 2 +- bin/setup | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100755 bin/setup diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index eb96d3cd..d94218e9 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -14,7 +14,7 @@ Before engaging with this community, please read and understand our ## Setting up development environment * The gem follows standard Rails practices: - * `bundle install` to install dependencies + * `bin/setup` to install dependencies * `bin/rails server` to start the server * `bin/rails test` to run tests * `bin/rails test:system` to run system tests diff --git a/bin/setup b/bin/setup new file mode 100755 index 00000000..3b6facc3 --- /dev/null +++ b/bin/setup @@ -0,0 +1,6 @@ +#!/bin/sh + +set -ex + +bundle install +bin/rails db:setup