You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pagy is a nice, simple pagination gem that we turned to for paginating previous runs. However, it uses offset, which is prohibited in Shopify Core:
and just generally won't scale well. Plus, most apps don't really need paginated runs since they'll just run a Task once. It might be worthwhile to investigate removing Pagy and implementing some sort of value-based pagination, or even dropping pagination and allowing users to load more data on their page with a button click at the bottom of their page.
The text was updated successfully, but these errors were encountered:
I saw your linked PR and it seems you have a pretty good handle on things but wanted to link a similar issue we had in Partners. We analyzed the performance implications of value-based pagination vs offset-based pagination. Not only is the performance better but it's also more reliable as documents change.
That's an awesome writeup, thanks for sharing @simonlevasseur ! ❤️ The more I read up on the two, the more apparent it became that we should make the switch, but it's really neat to see the performance implications in an actual production application.
Pagy is a nice, simple pagination gem that we turned to for paginating previous runs. However, it uses offset, which is prohibited in Shopify Core:
and just generally won't scale well. Plus, most apps don't really need paginated runs since they'll just run a Task once. It might be worthwhile to investigate removing Pagy and implementing some sort of value-based pagination, or even dropping pagination and allowing users to load more data on their page with a button click at the bottom of their page.
The text was updated successfully, but these errors were encountered: