Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Snapper generator for RDoc #292

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Use Snapper generator for RDoc #292

merged 2 commits into from
Mar 14, 2024

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Mar 14, 2024

To match ruby-lsp, based on Shopify/ruby-lsp#1384.

@andyw8
Copy link
Contributor Author

andyw8 commented Mar 14, 2024

Looking into this failure:

ruby-lsp-rails andyw8/rdoc-snapper % bundle exec rake rdoc                   
rake aborted!
LoadError: cannot load such file -- /Users/andyw8/.gem/ruby/3.3.0/bundler/gems/rdoc-dbabc13c8cee/lib/rdoc/markdown (LoadError)
/Users/andyw8/.gem/ruby/3.3.0/gems/zeitwerk-2.6.13/lib/zeitwerk/kernel.rb:34:in `require'
/Users/andyw8/.gem/ruby/3.3.0/bundler/gems/rdoc-dbabc13c8cee/lib/rdoc/text.rb:24:in `<module:Text>'
/Users/andyw8/.gem/ruby/3.3.0/bundler/gems/rdoc-dbabc13c8cee/lib/rdoc/text.rb:11:in `<top (required)>'
/Users/andyw8/.gem/ruby/3.3.0/gems/zeitwerk-2.6.13/lib/zeitwerk/kernel.rb:34:in `require'
/Users/andyw8/.gem/ruby/3.3.0/bundler/gems/rdoc-dbabc13c8cee/lib/rdoc/code_object.rb:30:in `<class:CodeObject>'
/Users/andyw8/.gem/ruby/3.3.0/bundler/gems/rdoc-dbabc13c8cee/lib/rdoc/code_object.rb:28:in `<top (required)>'
/Users/andyw8/.gem/ruby/3.3.0/gems/zeitwerk-2.6.13/lib/zeitwerk/kernel.rb:34:in `require'
/Users/andyw8/.gem/ruby/3.3.0/bundler/gems/rdoc-dbabc13c8cee/lib/rdoc/generator/markup.rb:60:in `<top (required)>'
/Users/andyw8/.gem/ruby/3.3.0/bundler/gems/rdoc-dbabc13c8cee/lib/rdoc/generator/darkfish.rb:7:in `require_relative'
/Users/andyw8/.gem/ruby/3.3.0/bundler/gems/rdoc-dbabc13c8cee/lib/rdoc/generator/darkfish.rb:7:in `<top (required)>'
/Users/andyw8/.gem/ruby/3.3.0/bundler/gems/rdoc-dbabc13c8cee/lib/rdoc/rdoc.rb:561:in `require_relative'
/Users/andyw8/.gem/ruby/3.3.0/bundler/gems/rdoc-dbabc13c8cee/lib/rdoc/rdoc.rb:561:in `<top (required)>'
/Users/andyw8/.gem/ruby/3.3.0/gems/zeitwerk-2.6.13/lib/zeitwerk/kernel.rb:34:in `require'
/Users/andyw8/.gem/ruby/3.3.0/bundler/gems/rdoc-dbabc13c8cee/lib/rdoc/task.rb:251:in `block in define'
/Users/andyw8/.gem/ruby/3.3.0/gems/rake-13.1.0/exe/rake:27:in `<top (required)>'
/Users/andyw8/.gem/ruby/3.3.0/gems/bundler-2.5.6/lib/bundler/cli/exec.rb:58:in `load'
/Users/andyw8/.gem/ruby/3.3.0/gems/bundler-2.5.6/lib/bundler/cli/exec.rb:58:in `kernel_load'
/Users/andyw8/.gem/ruby/3.3.0/gems/bundler-2.5.6/lib/bundler/cli/exec.rb:23:in `run'
/Users/andyw8/.gem/ruby/3.3.0/gems/bundler-2.5.6/lib/bundler/cli.rb:451:in `exec'
/Users/andyw8/.gem/ruby/3.3.0/gems/bundler-2.5.6/lib/bundler/vendor/thor/lib/thor/command.rb:28:in `run'
/Users/andyw8/.gem/ruby/3.3.0/gems/bundler-2.5.6/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
/Users/andyw8/.gem/ruby/3.3.0/gems/bundler-2.5.6/lib/bundler/vendor/thor/lib/thor.rb:527:in `dispatch'
/Users/andyw8/.gem/ruby/3.3.0/gems/bundler-2.5.6/lib/bundler/cli.rb:34:in `dispatch'
/Users/andyw8/.gem/ruby/3.3.0/gems/bundler-2.5.6/lib/bundler/vendor/thor/lib/thor/base.rb:584:in `start'
/Users/andyw8/.gem/ruby/3.3.0/gems/bundler-2.5.6/lib/bundler/cli.rb:28:in `start'
/Users/andyw8/.gem/ruby/3.3.0/gems/bundler-2.5.6/exe/bundle:28:in `block in <top (required)>'
/Users/andyw8/.gem/ruby/3.3.0/gems/bundler-2.5.6/lib/bundler/friendly_errors.rb:117:in `with_friendly_errors'
/Users/andyw8/.gem/ruby/3.3.0/gems/bundler-2.5.6/exe/bundle:20:in `<top (required)>'
/Users/andyw8/.gem/ruby/3.3.0/bin/bundle:25:in `load'
/Users/andyw8/.gem/ruby/3.3.0/bin/bundle:25:in `<main>'
Tasks: TOP => rdoc => docs/created.rid
(See full trace by running task with --trace)

@andyw8 andyw8 marked this pull request as ready for review March 14, 2024 17:36
@andyw8 andyw8 requested a review from a team as a code owner March 14, 2024 17:36
@andyw8 andyw8 requested review from KaanOzkan and vinistock March 14, 2024 17:36
@andyw8
Copy link
Contributor Author

andyw8 commented Mar 14, 2024

^ It's related to the Ruby version, fixed by setting to 3.2 as we do in ruby-lsp.

@andyw8 andyw8 merged commit d17f921 into main Mar 14, 2024
54 checks passed
@andyw8 andyw8 deleted the andyw8/rdoc-snapper branch March 14, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants