Start passing relevant capabilities to runtime server #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
KaanOzkan
approved these changes
Jan 28, 2025
vinistock
force-pushed
the
01-27-start_passing_relevant_capabilities_to_runtime_server
branch
from
775f82d to
fa8c7d6
Compare
vinistock
force-pushed
the
01-27-allow_server_to_send_asynchronous_notifications_to_client
branch
2 times, most recently
from
af129b9 to
6f78016
Compare
vinistock
force-pushed
the
01-27-start_passing_relevant_capabilities_to_runtime_server
branch
from
fa8c7d6 to
4f05db9
Compare
vinistock
force-pushed
the
01-27-allow_server_to_send_asynchronous_notifications_to_client
branch
from
6f78016 to
86ca9fa
Compare
vinistock
force-pushed
the
01-27-start_passing_relevant_capabilities_to_runtime_server
branch
from
4f05db9 to
4c8d1d1
Compare
vinistock
changed the base branch from
01-27-allow_server_to_send_asynchronous_notifications_to_client
to
graphite-base/560
vinistock
force-pushed
the
graphite-base/560
branch
from
86ca9fa to
7fe045a
Compare
vinistock
force-pushed
the
01-27-start_passing_relevant_capabilities_to_runtime_server
branch
from
4c8d1d1 to
6e843b8
Compare
vinistock
force-pushed
the
01-27-start_passing_relevant_capabilities_to_runtime_server
branch
from
6e843b8 to
42fed3b
Compare
Merge activity
|
vinistock
deleted the
01-27-start_passing_relevant_capabilities_to_runtime_server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to support server initiated progress, it will need to know if the editor connecting to the LSP actually supports it, otherwise we risk sending notifications that the client cannot handle.
My proposal is that we start passing a JSON containing only the relevant client capabilities to the server, so that we can check what is enabled.