Handle attribute_method_matchers rename to attribute_method_patterns #811
+28
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tapioca is failing on Rails edge because of the method rename
https://github.com/rails/rails/pull/44367/files
Implementation
If I'm not mistaken, we can't to rely on any particular Rails version in this case so taking
respond_to?
approach similar totapioca/lib/tapioca/dsl/compilers/active_model_attributes.rb
Lines 79 to 85 in 97b2790
I'm also renaming references to values from
matcher
topattern
according to the new terminology. Let me know if you think this is unnecessary.Tests
I'm going to run tests against Rails edge but I don't think there is any test I can add to existing ones?