-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop ios 10,11,12 support in browserslist-config #271
Comments
Yo @jasonkemp9099, can you confirm what the minimum supported iOS version is now? https://vault.shopify.io/projects/18219#status-update-103391 suggests 13.6? |
@BPScott that's correct! |
@jasonkemp9099 thanks for confirming! It looks like browserslist is slightly funky around it's unusual storage of ios safari versions. To support 13.6, we need to target
While |
All done for now! Well, the version of sk containing the PR to update the browserslist config hasn't yet been released, but that'll be done soon enough. We can update targets in quilt at a later date - bumping minimum node versions to |
In our browserslist config we target ios/safari 10 as a minimum version. This is old and can be updated.
This is because Shopify mobile apps supported ios 10 and they sometimes rendered webviews that shown pages from web apps. Thus the web apps needed to support ios 10 too.
As part of the Drop ios 10,11,12 Vault project mobile apps dropped support for ios 10,11 and 12, on June 1st. This meant the newest version of the apps will not install on ios versions older than 13. However there are existing apps already installed on ios 10/11/12 devices. The mobile team specified a guideline that web apps that render webviews used within mobile apps may drop support for older ios devices one month after the apps themselves drop support. See discussion in https://github.com/Shopify/core-issues/issues/23657.
As of July 1st (i.e. right now) we can drop support for ios 10,11 and 12 in our web properties - updating our minimum supported ios version to match the ios apps.
Use
npx browserlist "SOMEQUERY"
to determine the right query to use. I note strangelynpx browserslist "ios_saf >= 13.6"
does not return the known browser "ios_saf 13.4-13.7" yay bugs :(Work to be done:
safari
andios
keys. This is a breaking change. :: Bump Safari / iOS minimum supported versions #274sewing-kit
to depend up on the new version of browserslist-config and release the change. Write a migration guide that tells people to update their local version fo@shopify/browserslist-config
if they have one in place of the defaults sk provides :: https://github.com/Shopify/sewing-kit/pull/2788The text was updated successfully, but these errors were encountered: