Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect YJIT coverage regressions? #366

Open
maximecb opened this issue Nov 27, 2024 · 0 comments
Open

Automatically detect YJIT coverage regressions? #366

maximecb opened this issue Nov 27, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@maximecb
Copy link
Contributor

In the past I suggested that we could automatically detect performance regressions. There are some challenges with that because obviously some benchmarks can be noisy, may have to be manually excluded.

However recently Randy flagged a stats regression on railsbench. We wouldn't have spotted it if he hadn't noticed it. I was thinking that it may be easier to detect regressions in the "ratio in YJIT" than in execution time. So this might be a good place to have an automatic tripwire. We have a lot of benchmarks, so this give us lots of opportunities to detect regressions there.

I know that stats aren't always 100% deterministic, but they do tend to end up fairly stable, so in theory we could have a threshold of 1 or 2%. I believe it already is, but we should make sure that the number of iterations for the stats run is fixed to increase determinism. If some benchmarks have too much stats variability between runs, then we should either manually exclude them (annotation in benchmarks.yml?), or ideally identify and remove sources of non-determinism if possible (make sure all RNGs are seeded, etc).

@maximecb maximecb added the enhancement New feature or request label Nov 27, 2024
@rwstauner rwstauner self-assigned this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants