Permissions and ownership of vessel.json #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows user pi to edit vessel settings file
tkurki
reviewed
Nov 30, 2016
| @@ -109,6 +109,10 @@ cat > $vesselJson <<jsonfile | |||
| } | |||
| jsonfile | |||
|
|
|||
| sudo chmod 644 $vesselJson | |||
| sudo chown pi $vesselJson | |||
There was a problem hiding this comment.
Could the user be and not hardcoded pi?
There was a problem hiding this comment.
Yes, but as the script is run as root, wouldn't that become root?
There was a problem hiding this comment.
tmp tjk$ sudo chown root foo.txt
tmp tjk$ ls -l foo.txt
-rw-r--r-- 1 root wheel 1 Dec 1 10:49 foo.txt
tmp tjk$ sudo chown $USER foo.txt
tmp tjk$ ls -l foo.txt
-rw-r--r-- 1 tjk wheel 1 Dec 1 10:49 foo.txt
As I understand it $USER is evaluated before calling sudo.
Another method would be to use a variable: assign it, then use it on the sudo line.
There was a problem hiding this comment.
$SUDO_USER does the trick, it finds the user who invoked sudo. Not sure about group though
|
user and group not hard coded any more. Ok to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows user pi to edit vessel settings file