Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed period AIS subscription loses updates #230

Merged
merged 1 commit into from
Jul 2, 2017

Conversation

vokkim
Copy link
Contributor

@vokkim vokkim commented Jul 2, 2017

Fix for issue: #220

Fixes subscription protocol when subscribing to AIS targets with fixed period:

{
  context: 'vessels.*',
  subscribe: [
    {path: '*', period: 10000}
  ]
}

Previous implementation lost vessel data while sampling the incoming events. This fix will buffer all incoming filteredBus events and ensure that one value for each vessel+source+path will be emitted after the given period.

Remaining issues:

  • Several delta events will be emitted simultaneously on every period, each containing only one updates value. Optimal solution would emit only one delta event containing everything, but this would require some changes to the internal subscription architecture.
  • minPeriod is left untouched and will still lose some AIS vessel data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants