Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: allow server configuration, plugin configuration and defaults to be separate from the server install #232

Merged
merged 7 commits into from
Sep 2, 2017

Conversation

sbender9
Copy link
Member

@sbender9 sbender9 commented Jul 3, 2017

No description provided.

@tkurki
Copy link
Member

tkurki commented Jul 3, 2017

How about

  • some documentation
  • option to use an environment variable to specify the directory

@tkurki
Copy link
Member

tkurki commented Jul 3, 2017

README.md Outdated
==========================================================
You can store configuration like the settings file, plugin cofiguration, defaults.js and the mapcache in a directory outside of the server install using the `-c` option (or the `SIGNALK_NODE_CONDFIG_DIR` env variable).

For example, `./bin/signalk-server -c /usr/local/etc/node_server_config -s settings/my-boat.json`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the settings directory makes any sense here, as it exists to group the different examples together in one directory, and in this case there will be just one that could have a standard name, foregoing the need for the -s argument.

@@ -57,9 +57,21 @@ You can also configure the path to the settings file with environment variable `

The http port can be configured separately with environment variable `PORT`. You can also [run on port 80 with systemd](https://github.com/tkurki/marinepi-provisioning/blob/d3d624629799a3b96234a90fc42bc22dae4fd3a2/roles/node-app/templates/node_app_systemd_socket.j2). Environment variable NMEA0183PORT sets the NMEA 0183 tcp port.

Storing Configuration Outside The Server Install Directory
==========================================================
You can store configuration like the settings file, plugin cofiguration, defaults.js and the mapcache in a directory outside of the server install using the `-c` option (or the `SIGNALK_NODE_CONDFIG_DIR` env variable).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

README.md Outdated

For example, `./bin/signalk-server -c /usr/local/etc/node_server_config -s settings/my-boat.json`

In this case it will find my-boat.json at `/usr/local/etc/node_server_confif/settings/my-boat.json`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

README.md Outdated

In this case it will find my-boat.json at `/usr/local/etc/node_server_confif/settings/my-boat.json`.

You would also put the charts mapcache directory here under `public/mapcache`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does here refer to` Could be spelled out to match the example above?

@sbender9 sbender9 changed the title feature: allow server configuration, plugin configuration, defaults and samples to be separate from the server install feature: allow server configuration, plugin configuration and defaults to be separate from the server install Sep 1, 2017
@tkurki tkurki merged commit bbe48c0 into SignalK:master Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants