Plugin delta logging #400
Merged
Plugin delta logging #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkurki
reviewed
Jan 11, 2018
| var plugin = app.pluginsMap[providerId] | ||
| if ( | ||
| !_.isUndefined(plugin) && | ||
| app.config.settings.enablePluginLogging && |
There was a problem hiding this comment.
More consistent naming: ...pluginsLoggingEnabled
… code and allow execution from global npm install
Install plugins and webapps in the config directory instead of the server install's / global node_modules to retain them over server reinstalls and updates. Change code to require plugins from the config directory and mount webapps from there.
…ave when installing plugins
Npm takes care of formatting package.json.
Move Dockerfile from root to /docker to speed up local builds, as the build does not use any local files. Install from npm.
…erver-node into plugin-logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The add the ability include deltas coming from plugins in the logs