Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add support for native canboatjs #429

Merged
merged 16 commits into from
Feb 2, 2018
Merged

feature: add support for native canboatjs #429

merged 16 commits into from
Feb 2, 2018

Conversation

sbender9
Copy link
Member

@sbender9 sbender9 commented Jan 27, 2018

Canboatjs in a port of the canboat project to javascript. This allows the node server to process N2K data without having to download, build and install canboat.

Please see Canboatjs for more information.

@sbender9 sbender9 changed the title [WIP] feature: add support for native canboajs feature: add support for native canboajs Jan 27, 2018
@sbender9 sbender9 changed the title feature: add support for native canboajs feature: add support for native canboatjs Jan 27, 2018
@tkurki
Copy link
Member

tkurki commented Jan 28, 2018

native is a but ambiguous, as it may mean calling native code from JavaScript. How about using the term pure js or pure JavaScript instead? That should not be hard to miss.

Documentation should be updated as well, the segment where it says you need to install canboat. And maybe bin/n2k-from-file-js and a settings file to go with it?

I'd like to get #431 in so that we don't need to update the js bundles in cases like this, but either can go in first.

@sbender9
Copy link
Member Author

I didn't want to change the documentation until I get some more testing done

@tkurki tkurki merged commit 5216b01 into master Feb 2, 2018
@tkurki tkurki deleted the canboatjs branch February 2, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants