feature: implement access control lists #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbender9
changed the title
tkurki
changed the title
tkurki
reviewed
Feb 19, 2018
lib/tokensecurity.js
Outdated
| @@ -546,6 +562,19 @@ module.exports = function (app, config) { | |||
| return false | |||
| } | |||
|
|
|||
| strategy.isDummy = () => { | |||
| return false | |||
| } | |||
There was a problem hiding this comment.
If your function is a oneline that returns a value you do it like () => false, without the curly braces to save a few lines
|
I'm thinking we could make the defaults handling a separate effort. That's going to be a big job I think. This currently provides the same functionality with defaults as |
sbender9
force-pushed
the
access-control-lists
branch
from
306d3eb to
d87720d
Compare
sbender9
changed the title
sbender9
changed the title
tkurki
force-pushed
the
access-control-lists
branch
2 times, most recently
from
ad7c2ca to
4ce828d
Compare
Move token security strategy into server codebase and implement acls in rest calls.
tkurki
force-pushed
the
access-control-lists
branch
from
4ce828d to
552479c
Compare
sbender9
changed the title
Implement acls by using normalized deltas, which are single delta data with all related fields. Subscription/ws deltas are built from normalised deltas. Latest values per path per source are kept in deltacache and full responses are built on the fly checking access control rules in the process.
sbender9
force-pushed
the
access-control-lists
branch
from
f426de5 to
39c322f
Compare
For example. /signalk/v1/api/vessels/self/navigation/position/value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: