Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let user possibility to interact directly with target widget #261

Closed
Dekhnar opened this issue Aug 7, 2022 · 8 comments · Fixed by #266
Closed

let user possibility to interact directly with target widget #261

Dekhnar opened this issue Aug 7, 2022 · 8 comments · Fixed by #266
Assignees
Labels
enhancement New feature or request

Comments

@Dekhnar
Copy link

Dekhnar commented Aug 7, 2022

Is your feature request related to a problem? Please describe.
No.

Describe the solution you'd like
My targeted widget has two buttons, one for accepting the other for refusing. I would be nice, if you can propagate gesture event to the target children for letting the user ability to click on those buttons and managing the showcase flow manually?
Currently onTap from TargetWidget handles the event and then stops propagating.

@Dekhnar
Copy link
Author

Dekhnar commented Aug 9, 2022

I find a workaround and programmatically running my wanted action.

@DhavalRKansara
Copy link
Collaborator

@Dekhnar It will be great if you can share some information regarding the same feature you required in way of code, screenshots or workaround you have found.

@DhavalRKansara DhavalRKansara added help wanted Extra attention is needed question Further information is requested labels Aug 10, 2022
@Dekhnar
Copy link
Author

Dekhnar commented Aug 11, 2022

I used onTargetClick function exposed by Showcase Widget to fired an event into my event bus, listen to this event and then execute my action.

@Dekhnar
Copy link
Author

Dekhnar commented Aug 11, 2022

@DhavalRKansara I would be great if we can manually manage gesture. Maybe possible by letting us set null onTap, onLongPress, onDoubleTap there :


Or letting us change the hitBehavior

@DhavalRKansara
Copy link
Collaborator

@Dekhnar Sure, We will check on it from our end we will let you know if plan to make those changes...

@DhavalRKansara DhavalRKansara added enhancement New feature or request and removed help wanted Extra attention is needed question Further information is requested labels Aug 17, 2022
@vatsaltanna
Copy link
Collaborator

Hi @Dekhnar , I tried to investigate your suggestion and I belive the current behaviour is implemented because usually the target widget has their own action(like screen change) which is not required to be performed while showcase of the application feature. And even if that is the necessory behaviour then user can use the different call back of gesture like onTap, onDoubleTap or onLongPress. Please let us know if there is any other usecase you require ?

@vatsaltanna vatsaltanna added more-info-required Provide more information and removed enhancement New feature or request labels Aug 20, 2022
@Dekhnar
Copy link
Author

Dekhnar commented Aug 21, 2022

Hi @vatsaltanna, for example if you want to let the user swiping a card to the right, onTap, onDoubleTap, orLongPress will not be enought. By letting us setting behaviour on the focused area, we will be able to catch these king of gesture.

@vatsaltanna
Copy link
Collaborator

Got it, Thanks for the information. I will work on this feature soon. Thanks for reporting.

@vatsaltanna vatsaltanna added enhancement New feature or request and removed more-info-required Provide more information labels Aug 21, 2022
@vatsaltanna vatsaltanna self-assigned this Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants