org.openrewrite.java.testing.junit5.JUnit4to5Migration fails to migrate public TemporaryFolder folder = new TemporaryFolder();

[nagkumar]

rewrite {
    activeRecipe(
	//"org.openrewrite.java.RemoveUnusedImports",
	//            "dev.simonverhoeven.sampleRecipe",
	"org.openrewrite.java.testing.junit5.JUnit4to5Migration",

demo\src\test\java\dev\simonverhoeven\openrewritedemo\JUnitTest.java:25: error: no suitable constructor found for File(no arguments)
    public File folder = new File();
                         ^
    constructor File.File(String,int) is not applicable
      (actual and formal argument lists differ in length)
    constructor File.File(String,File) is not applicable
      (actual and formal argument lists differ in length)
    constructor File.File(String) is not applicable
      (actual and formal argument lists differ in length)
    constructor File.File(String,String) is not applicable
      (actual and formal argument lists differ in length)
    constructor File.File(File,String) is not applicable
      (actual and formal argument lists differ in length)
    constructor File.File(URI) is not applicable
      (actual and formal argument lists differ in length)

[nagkumar]

converts into

@Tag("DemoTag")
public class JUnitTest
{
    public File folder = new File();

    @BeforeEach
    public void beforeEachTest()
    {
    }

    @AfterEach
    public void afterEachTest()
    {
    }

    @Disabled
    public void importantTest()
    {
	// validate

[nagkumar]

https://docs.openrewrite.org/recipes/java/testing/junit5/temporaryfoldertotempdir?q=TemporaryFolder

it is supposed to use this receipe but not working

[SimonVerhoeven]

Hello, did you add any other recipes & did you enable rewrite-testing-frameworks?
I verified it just now, and when I execute it I get:

@TempDir
public File folder;

Which is the expected migration from TemporaryFolder

[nagkumar]

Nope.. even with latest rewrite version.. it gives

I am using JDK 17.0.8 would that be an issue

My build file

plugins {
    `java-library`
    id("org.openrewrite.rewrite") version "6.3.16"
    id("com.github.ben-manes.versions") version ("0.48.0")
    id("se.patrikerdes.use-latest-versions") version ("0.2.18")
}

repositories {
    mavenCentral()
}
rewrite {
    activeRecipe(
	//"org.openrewrite.java.AddApache2LicenseHeader",
	//"org.openrewrite.java.logging.log4j.Log4j1ToLog4j2",
	//"org.openrewrite.staticanalysis.RemoveSystemOutPrintln",
	//"org.openrewrite.java.logging.SystemOutToLogging",
	//"org.openrewrite.java.migrate.UpgradeToJava17",
	"org.openrewrite.java.testing.junit5.JUnit4to5Migration",
	//"org.openrewrite.java.spring.boot3.UpgradeSpringBoot_3_1",

	//"org.openrewrite.gradle.DependencyUseStringNotation",
	//"org.openrewrite.java.RemoveUnusedImports",
	//"com.teja.rac.AutoChangePackage",
	//"org.openrewrite.java.migrate.guava.NoGuava",
	//"org.openrewrite.java.testing.hamcrest.MigrateHamcrestToAssertJ",
	//"org.openrewrite.staticanalysis.CommonStaticAnalysis",
	//"org.openrewrite.java.logging.slf4j.ParameterizedLogging",
	//"org.openrewrite.java.security.JavaSecurityBestPractices",
	//"org.openrewrite.cloudsuitability.FindFileIo",
	//"org.openrewrite.cloudsuitability.FindCacheUses",
	//"org.openrewrite.cloudsuitability.FindUnsuitableCode",
	//"org.openrewrite.java.security.OwaspTopTen",
		)
}

dependencies {
    rewrite(platform("org.openrewrite.recipe:rewrite-recipe-bom:2.2.0"))
    rewrite("org.openrewrite.recipe:rewrite-testing-frameworks")
    //rewrite("org.openrewrite.recipe:rewrite-spring")
    //rewrite("org.openrewrite.recipe:rewrite-migrate-java")
    //rewrite("org.openrewrite.recipe:rewrite-static-analysis")
    //rewrite("org.openrewrite.recipe:rewrite-java-dependencies")
    //rewrite("org.openrewrite.recipe:rewrite-logging-frameworks")
    //rewrite("org.openrewrite.recipe:rewrite-java-security")
    //rewrite("org.openrewrite.recipe:rewrite-cloud-suitability-analyzer")

    api("org.springframework.boot:spring-boot-starter:2.7.13")
    api("org.springframework.boot:spring-boot-starter-web:2.7.13")
    api("log4j:log4j:1.2.17")
    api("com.google.guava:guava:20.0")
    testImplementation("org.hamcrest:hamcrest:2.2")
    testImplementation("junit:junit:4.13.2")

    //testImplementation("org.junit.jupiter:junit-jupiter:5.10.0")
    //testImplementation("org.assertj:assertj-core:3.24.2")
}

[nagkumar]

---

Gradle 8.3

Build time: 2023-08-17 07:06:47 UTC
Revision: 8afbf24b469158b714b36e84c6f4d4976c86fcd5

Kotlin: 1.9.0
Groovy: 3.0.17
Ant: Apache Ant(TM) version 1.10.13 compiled on January 4 2023
JVM: 17.0.8 (Oracle Corporation 17.0.8+9-LTS-211)
OS: Windows 10 10.0 amd64

[nagkumar]

Also, this rewrite is not changing gradle dependencies from 4.x to 5.x, is that the expected behavior

[SimonVerhoeven]

hmm, I can't reproduce your issue using the sample repository => ./gradlew rewriteRun when I just enable the JUnit recipe. It's also odd that it's doing a fully different replacement. I'd recommend creating a ticket at https://github.com/openrewrite/rewrite-testing-frameworks and sharing the results of the rewriteRun task.

As to your second question, that's an in-progress enhancement for Kotlin: openrewrite/rewrite#3291