Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated instances are logged in debug but not printed #8386

Open
live627 opened this issue Dec 31, 2024 · 1 comment
Open

Integrated instances are logged in debug but not printed #8386

live627 opened this issue Dec 31, 2024 · 1 comment

Comments

@live627
Copy link
Contributor

live627 commented Dec 31, 2024

SMF/Sources/Utils.php

Lines 2487 to 2492 in 5a0150e

if (!empty(Config::$db_show_debug)) {
if (!isset(Utils::$context['debug']['instances'])) {
Utils::$context['debug']['instances'] = [];
}
Utils::$context['debug']['instances'][$class] = $class;

What should be done here? Remove this code or print class names?

Tagging @MissAllSunday

@MissAllSunday
Copy link
Contributor

I remember for 2.1 it made sense to print out instances because very few mod authors will actually be using them (I don't have specifics but I believe the number of mods using instances, not static calls, is still small).

But even if the number of mods using instances increases, it makes sense to have that info while debugging, perhaps we could expand that a little bit by also including static calls and plain functions as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants