forked from jortilles/EDA
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mejora - API - Refactorización de Update Model #260
Draft
juanSTIC
wants to merge
23
commits into
reporting
Choose a base branch
from
newCleanModel3
base: reporting
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanSTIC
requested review from
jortilles,
AlbertoSTIC,
PaulaaSTIC and
ronaldchavezjortilles
December 10, 2024 16:46
juanSTIC
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Dec 10, 2024
juanSTIC
changed the title
New clean model3
Mejora - API - Refactorización de Update Model
Dec 10, 2024
juanSTIC
removed request for
jortilles,
AlbertoSTIC,
PaulaaSTIC and
ronaldchavezjortilles
December 12, 2024 12:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
SinergiaDA
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔄 Cambios principales
📝 Detalles técnicos
Sincronización de usuarios y grupos (
usersAndGroupsToMongo.ts
)Limpieza del modelo (
cleanModel.ts
)Controlador de actualización (
updateModel.controller.ts
)🛠 Mejoras de rendimiento
Otros cambios aplicados
Se ha aprovechado el PR para aplicar otros cambios necesarios:
Sobre el idioma:. Para facilitar la validación y potenciales cambios a realizar se han dejado los comentarios en español, con la idea de hacer un último cambio una vez validada la funcionalidad y el código para pasarlos a inglés.
Pruebas a realizar
Usuario y grupos
Verificar siempre tras ejecutar updateModel
Cambios en SinergiaCRM
Cambios en SinergiaDA
Permisos
Verificar siempre tras ejecutar rebuild + updateModel
Cambios en SinergiaCRM
Cambios en SinergiaDA