Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering host sample setup issues #339

Closed
vitaliitylyk opened this issue Mar 5, 2020 · 3 comments
Closed

Rendering host sample setup issues #339

vitaliitylyk opened this issue Mar 5, 2020 · 3 comments

Comments

@vitaliitylyk
Copy link
Contributor

Description

The React sample app implementation has 2 issues in rendering host setup:

  1. There is a missing "@sitecore-jss/sitecore-jss-rendering-host": "^13.0.2" dependency in packages.json
  2. /scripts/http-renderer.js is pointing to /build-rendering-host/ folder, while build scripts are copying output to the /build/ folder

I can submit a PR with a fix, however not sure about the second issue. It seems there is no out-of-the box way to specify output directory for react-scripts build command: facebook/create-react-app#1354
What are your thoughts on this?

@anastasiya29
Copy link
Contributor

Regarding issue 1 - isn't the use of the new rendering host optional? Users can continue using the old-school http method. Or does the missing reference cause errors even when using the old render method?

@vitaliitylyk
Copy link
Contributor Author

Good point, it is optional and it does not cause any errors when using the old render method. However since this is a sample app I would expect everything to work without extra modifications (e.g if start:rendering-host npm script is defined - it should just work)

@sc-illiakovalenko
Copy link
Contributor

@vitaliitylyk I provided my fixes in #394 , and merged your changes #355. Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants