-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rendering host sample setup issues #339
Comments
Regarding issue 1 - isn't the use of the new rendering host optional? Users can continue using the old-school http method. Or does the missing reference cause errors even when using the old render method? |
Good point, it is optional and it does not cause any errors when using the old render method. However since this is a sample app I would expect everything to work without extra modifications (e.g if |
@vitaliitylyk I provided my fixes in #394 , and merged your changes #355. Good job! |
Description
The React sample app implementation has 2 issues in rendering host setup:
I can submit a PR with a fix, however not sure about the second issue. It seems there is no out-of-the box way to specify output directory for react-scripts build command: facebook/create-react-app#1354
What are your thoughts on this?
The text was updated successfully, but these errors were encountered: