Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imageParams on Image react component don't play nice with allowedMediaParams #428

Closed
ssartell opened this issue Aug 11, 2020 · 1 comment

Comments

@ssartell
Copy link

ssartell commented Aug 11, 2020

Description

The adding the same values to imageParams in an Image component and allowedMediaParams in a patch config does not result in an image getting sized correct. The original media URL coming from the layout service includes original h/w/iar/hash parameters that aren't getting cleared when mediaApi.updateImageUrl gets called. This appears to have changed as part of issue #172 and PR #275 .

Expected behavior

Passing in the exact same parameters to imageParams and allowedMediaParams should result in an image getting sized correctly.

Steps To Reproduce

  1. Create an Image instance with imageParams.
  2. Add the exact same imageParams to the allowedMediaParams patch config.
  3. Look at the rendered image to see if it's sized correctly based on the params.

Possible Fix

Revert the change to the mediaApi.

@sc-illiakovalenko
Copy link
Contributor

@ssartell Fixed in #449. Will be released in JSS 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants