Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component name is "Unknown" for Npgsql.EntityFrameworkCore.PostgreSQL #497

Closed
1 of 4 tasks
SummerZYQ opened this issue Aug 15, 2022 · 3 comments · Fixed by #498
Closed
1 of 4 tasks

component name is "Unknown" for Npgsql.EntityFrameworkCore.PostgreSQL #497

SummerZYQ opened this issue Aug 15, 2022 · 3 comments · Fixed by #498
Milestone

Comments

@SummerZYQ
Copy link

SummerZYQ commented Aug 15, 2022

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Question or discussion
  • Bug
  • Requirement
  • Feature or performance improvement

Question

  • What do you want to know?
    image
    this component value is "Unknown", but i'am use "Npgsql.EntityFrameworkCore.PostgreSQL"

Bug

  • Which version of SkyWalking, OS and .NET Runtime?
    skywalking-oap-server:9.1.0
    SkyAPM.Agent.AspNetCore:2.0.1

I think there is only save StringValue, but in SegmentV8Helpers.cs not use it.

context.Span.Component = new StringOrIntValue(metadataProvider.Component);

private static readonly Action<SpanObject, string> ComponentReader = (s, val) => { /*nolonger support*/};

@wu-sheng
Copy link
Member

Component ID is only used, name doesn't matter.

@SummerZYQ
Copy link
Author

Component ID is only used, name doesn't matter.

metadataProvider.Component is string, use it to context.Span.Component , lose the IntValue.

@wu-sheng
Copy link
Member

I don't know dotnet agent, I mean from protocol perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants