SkyApm Log exception

[sampsonye]

Please answer these questions before submitting your issue.

• Why do you submit this issue?
• Question or discussion
• [* ] Bug
• Requirement
• Feature or performance improvement

---

Question

• What do you want to know?

---

Bug

• Which version of SkyWalking, OS and .NET Runtime?

• Which company or project?

• What happen?
  If possible, provide a way for reproducing the error. e.g. demo application, component version.

Unhandled exception. System.AggregateException: An error occurred while writing to logger(s). (Object reference not set to an instance of an object.)
 ---> System.NullReferenceException: Object reference not set to an instance of an object.
   at SkyApm.Transport.SegmentContextMapper.Map(SegmentContext segmentContext)
   at SkyApm.Transport.LoggerContextContextMapper.Map(LoggerContext loggerContext)
   at SkyApm.Transport.AsyncQueueSkyApmLogDispatcher.Dispatch(LoggerContext loggerContext)
   at SkyApm.Diagnostics.MSLogging.SkyApmLogger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func`3 formatter)
   at Microsoft.Extensions.Logging.Logger.<Log>g__LoggerLog|12_0[TState](LogLevel logLevel, EventId eventId, ILogger logger, Exception exception, Func`3 formatter, List`1& exceptions, TState& state)
   --- End of inner exception stack trace ---
   at Microsoft.Extensions.Logging.Logger.ThrowLoggingError(List`1 exceptions)
   at Microsoft.Extensions.Logging.Logger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func`3 formatter)
   at Microsoft.Extensions.Logging.Logger`1.Microsoft.Extensions.Logging.ILogger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func`3 formatter)
   at Microsoft.Extensions.Logging.LoggerExtensions.Log(ILogger logger, LogLevel logLevel, EventId eventId, Exception exception, String message, Object[] args)
   at Microsoft.Extensions.Logging.LoggerExtensions.LogInformation(ILogger logger, String message, Object[] args)
   at DotNetCore.CAP.Processor.CapProcessingServer.Dispose()
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngineScope.DisposeAsync()
--- End of stack trace from previous location ---
   at Microsoft.Extensions.Hosting.Internal.Host.<DisposeAsync>g__DisposeAsync|16_0(Object o)
   at Microsoft.Extensions.Hosting.Internal.Host.DisposeAsync()
   at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.RunAsync(IHost host, CancellationToken token)
   at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.Run(IHost host)
   at Microsoft.AspNetCore.Builder.WebApplication.Run(String url)

---

Requirement or improvement

• Please describe about your requirements or improvement suggestions.

[KawhiWei]

In what scenario does this error occur? @sampsonye

[sampsonye]

In what scenario does this error occur? @sampsonye

Use Cap

[sampsonye]

In what scenario does this error occur? @sampsonye

i guess the bug is here:

Cap init before any IEntrySegmentContextAccessor may be there do not have any EntrySegment

[sampsonye]

Can we stop using the log extension?
i just want use skywalking as apm
and we have the profressional log center

[KawhiWei]

I want to know whether the problem occurs when Cap produces messages or when Cap consumes messages? @sampsonye

[sampsonye]

I want to know whether the problem occurs when Cap produces messages or when Cap consumes messages? @sampsonye

i say just in cap Bootstrap ,you can find it on exception stack

the really code just:

and you can make a test just do not have any EntrySegment

finally can we close this log? it is redundant for us

[liuhaoyang]

I want to know whether the problem occurs when Cap produces messages or when Cap consumes messages? @sampsonye

i say just in cap Bootstrap ,you can find it on exception stack

the really code just:

and you can make a test just do not have any EntrySegment

finally can we close this log? it is redundant for us

@GeorGeWzw I think it's reasonable to allow users to disable logging integration.

[sampsonye]

it seem like a critical fault
it make logger broken when we do not have init EntrySegment
Just happen Like:

1. some module that do not use skyapm like quartz,hangfire and so on
2. BackgroundService、HostService

@liuhaoyang @GeorGeWzw any suggestions?

[liuhaoyang]

I have removed the 2.1.0 release until this issue is fixed.

[liuhaoyang]

it seem like a critical fault it make logger broken when we do not have init EntrySegment Just happen Like:

1. some module that do not use skyapm like quartz,hangfire and so on
2. BackgroundService、HostService

@liuhaoyang @GeorGeWzw any suggestions?

I just re-reviewed the code LoggerContextContextMapper.cs#L34 should check if SegmentContext is null before mapping SegmentContext to segmentRequest