You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm profiling the startup times and memory consumption of some big Minecraft packs, looking for things that are causing minor issues when pushed to the limits.
Every call to getItemNN() creates new strings. This seems to be called a lot during startup when setting up things for JEI. This accounted for around 300 MB of strings when I was profiling JEI during startup of ATM3.
returnNullHelper.notnull(getItem(), "Item " + this + " is unexpectedly missing");
I think the usual way around this is to pass in a string with formatting args, use a lambda, or just inline the call so that a string is only created when there's an error.
The text was updated successfully, but these errors were encountered:
I'm profiling the startup times and memory consumption of some big Minecraft packs, looking for things that are causing minor issues when pushed to the limits.
Every call to
getItemNN()
creates new strings. This seems to be called a lot during startup when setting up things for JEI. This accounted for around 300 MB of strings when I was profiling JEI during startup of ATM3.EnderCore/src/main/java/com/enderio/core/common/util/stackable/IProducer.java
Line 26 in 62950c1
I think the usual way around this is to pass in a string with formatting args, use a lambda, or just inline the call so that a string is only created when there's an error.
The text was updated successfully, but these errors were encountered: