Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unpredictable number to JS ZK proofs #183

Open
jot2re opened this issue Aug 31, 2021 · 2 comments
Open

Add unpredictable number to JS ZK proofs #183

jot2re opened this issue Aug 31, 2021 · 2 comments
Assignees
Labels
Security A security issue that should be fixed, since it might allow for attacks. technical-debt

Comments

@jot2re
Copy link
Collaborator

jot2re commented Aug 31, 2021

The JS part of issue #167.
See section 2.2.1 in the Token-negotiator report.
See Jira issue 291.

@jot2re jot2re added the Security A security issue that should be fixed, since it might allow for attacks. label Oct 19, 2021
@micwallace
Copy link
Collaborator

@jot2re I'm keen to catch up about implemting this and packaging the JS library for use in TN and attestation.id. Message me on discord when you get a chance next week.

@jot2re
Copy link
Collaborator Author

jot2re commented May 13, 2022

@micwallace sorry I forgot to write you. This issue is still relevant. Currently the flow allows reuse of ZKPs. However, it seems like a very minimal change to get this fixed. I can try to make the changes needed in Token-negotiator and authenticator, but given I don't really have TS expertise I will need some help throughly validating and testing such changes. Let me know when you have time to look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Security A security issue that should be fixed, since it might allow for attacks. technical-debt
Projects
None yet
Development

No branches or pull requests

3 participants