Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Solidity according to new NFTattestation #206

Open
jot2re opened this issue Nov 15, 2021 · 1 comment
Open

Update Solidity according to new NFTattestation #206

jot2re opened this issue Nov 15, 2021 · 1 comment

Comments

@jot2re
Copy link
Collaborator

jot2re commented Nov 15, 2021

Update the Solidity code according to the refactoring done when handling issue #203 and #201

@oleggrib
Copy link
Collaborator

@jot2re in case if we implement #203 then SmartContract need to change single sinnature verification update. so whole object will be signed with attestor address.

And another suggestion - with new flow we can make simplier object with required fields only to save gas

so we need:

  • timestamp
  • nftsList
  • identifier
  • whole_Object_Signature_By_Attesdtation.id_Key

its enough for our task.

universal solution is a good option when data validation is free, but in our case use have to pay gas for our unification

cc @colourful-land , @JamesSmartCell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants