fix: Replace ss_mkt by bing_market to avoid anomaly detection #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss_mkt removed from the code to avoid anomaly detection
Replaced ss_mkt by bing_market.
Replace ss_mkt by bing_market, but let the options.
|
Can't edit the PR files, but the query in the search tests also need to be updated. |
Snazzah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be the best way to handle the problem with DDG anomaly detection. In production we simply removed ss_mkt and worked, but we are seeing other libraries such as duckduckgo_search.py using bing_market. I just set the default to en-US, but eventually there may be a better way.
"bing_market": f"{region[3:]}-{region[:2].upper()}",
https://github.com/sippulse/duck-duck-scrape/blob/master/src/search/search.ts