Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Required Animation Parameters for "doingNothing" Function in Plugin #134

Open
rmolazem opened this issue Jun 24, 2024 · 1 comment

Comments

@rmolazem
Copy link
Contributor

rmolazem commented Jun 24, 2024

I'm encountering an issue with the use of the "doingNothing" animation function in the plugin, which is originally designed for soft robotics applications. The plugin naturally includes actuators, requiring animation parameters to be set, namely "incr", "incrPeriod", and "rangeOfAction":

DefaultAnimation

However, when there are no actuators, and the "doingNothing" animation function is used, the plugin still mandates the setting of animation parameters, which are not utilized in this context. This results in unnecessary complications when trying to use the plugin without actuators:

doNothing

@VannesteFelix
Copy link
Collaborator

Hi @rmolazem,
thank you for bringing this forward. We need to address this issue.

The beautiful and well named DoingNothing function was just a quick fix allowing users to reduce without any actuator in their scene. You still need to give it parameters (that won't be used), it's just to respect the animation function convention.

More dev needs to be done in order to remove this ugly patch and change the code to allow user reducing without this mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants