🔀 :: (#121) 게시글 수정 API #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
softpeanut
reviewed
Jun 30, 2022
| @@ -49,4 +50,10 @@ public PublicFeed(String title, String content, Integer likeCount, Feed feed) { | |||
| this.likeCount = likeCount; | |||
| this.feed = feed; | |||
| } | |||
|
|
|||
| public void updateFeedContent(UpdateFeedRequest request) { | |||
There was a problem hiding this comment.
request 넘기는 것보다 title하고 content 나눠서 넘기는 게 좋을 것 같아여
|
|
||
| @ResponseStatus(HttpStatus.NO_CONTENT) | ||
| @DeleteMapping("/{feed-id}") | ||
| public void deleteFeed(@PathVariable("feed-id") Integer feedId) { | ||
| deleteFeedService.execute(feedId); | ||
| } | ||
|
|
||
| @ResponseStatus(HttpStatus.NO_CONTENT) | ||
| @PatchMapping("/{feed-id}") | ||
| public void updateFeed(@Valid @RequestBody UpdateFeedRequest request, @PathVariable("feed-id") Integer feedId) { |
| @NotBlank(message = "title은 Null, 공백, 띄어쓰기를 허용하지 않습니다.") | ||
| private String title; | ||
|
|
||
| @NotNull(message = "content은 Null일 수 없습니다.") |
ericlee05
reviewed
Jul 6, 2022
| PublicFeed publicFeed = feedFacade.getPublicFeedByFeedId(feed); | ||
| FeedAttachmentFile feedAttachmentFile = feedFacade.getFeedAttachmentFileByFeedId(feed); | ||
|
|
||
| if (!user.equals(feed.getUser())) { |
There was a problem hiding this comment.
이 if문을 publicFeed를 조회하기 이전에(라인 26과 27 사이) 넣으면 불필요한 조회(publicFeed, feedAttachmentFile)를 막을 수 있지 않을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #121