Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CreateToken call in demo-rollup/README.md with a transfer #476

Closed
neysofu opened this issue Jul 7, 2023 · 0 comments · Fixed by #479
Closed

Replace CreateToken call in demo-rollup/README.md with a transfer #476

neysofu opened this issue Jul 7, 2023 · 0 comments · Fixed by #479
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation Priority-Medium

Comments

@neysofu
Copy link
Member

neysofu commented Jul 7, 2023

Summary

The README.md in demo-rollup is not very clear on how to run the example CreateToken transaction right after make test-create-token.

  • If one tries to run it without make clean, the transaction is invalid because the same token was just created. Overall not a good UX.
  • If one tries to run it after running make clean, the transaction is also invalid because the example is using nonce=1.

Expected Result

We want the demo-rollup README to function correctly for all users and be hard to mess up.
After some discussion, we agreed on replacing the CreateToken call with a transfer as to work correctly after make test-create-token without any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation Priority-Medium
Projects
None yet
2 participants