Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM: Handle EVMError when the EVM execution fails #505

Closed
bkolad opened this issue Jul 17, 2023 · 2 comments
Closed

EVM: Handle EVMError when the EVM execution fails #505

bkolad opened this issue Jul 17, 2023 · 2 comments
Labels
evm

Comments

@bkolad
Copy link
Member

bkolad commented Jul 17, 2023

Description

Currently, when the EVM execution fails, the code panics. We need to come up with a solution to handle these EVM errors appropriately.

Acceptance Criteria

  1. Ensure that no panics occur during unsuccessful EVM execution.
  2. Implement unit tests to cover this specific case.
@bkolad bkolad added the evm label Jul 17, 2023
@bkolad
Copy link
Member Author

bkolad commented Sep 15, 2023

The last question to answer is if failed tx should consume all gas.

@orkunkilic orkunkilic mentioned this issue Sep 26, 2023
Merged
@orkunkilic
Copy link
Contributor

I think this was also related to eth_call so we can close @bkolad?

@bkolad bkolad closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
evm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bkolad @orkunkilic