Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quality handling in SceneChannel #13

Open
SpaceOgre opened this issue Dec 24, 2019 · 2 comments
Open

Update quality handling in SceneChannel #13

SpaceOgre opened this issue Dec 24, 2019 · 2 comments
Labels
enhancement New feature or request refactoring No new features just improving underlying code

Comments

@SpaceOgre
Copy link
Owner

SpaceOgre commented Dec 24, 2019

The hard coded values for quality in SceneChannel.js needs to be updated. High, medium and low is no longer used by Twitch, they use: 720p, 720p60 etc.

Atm the select start quality in code is high but since it does not exist auto will be used. I think auto should be the one to start with.

Option to choose start quality should be added to config.js

@SpaceOgre SpaceOgre added the enhancement New feature or request label Dec 24, 2019
@Fansh1ne
Copy link

Start quality on 3.9.2 is auto on that quality panel (and it was before too).

@SpaceOgre
Copy link
Owner Author

SpaceOgre commented Dec 24, 2019

Hmm that is weird when I look at the code it should be high 🤔

Ah it might be because the quality ids have changed, if no I'd match the given quality auto is chosen.

@SpaceOgre SpaceOgre changed the title Change start quality to source/auto Update quality handling in SceneChannel Dec 25, 2019
@SpaceOgre SpaceOgre added the refactoring No new features just improving underlying code label Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring No new features just improving underlying code
Projects
None yet
Development

No branches or pull requests

2 participants