-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chat #8
Comments
I think with chat feature this app would be complete. |
@Fansh1ne I have added a basic chat via embedding the chat in an iframe. This is the official way to do it according to Twitch. I'm not sure how good it will look on a TV or if it will work/lagg. Please test if you got the time. It is in this branch: https://github.com/SpaceOgre/smarttv-twitch/tree/feature/chat |
I have tried the one from the link above and app is not working at all. https://pixhost.to/show/268/130848828_img_20191223_222445.jpg |
That's weird, I have not changed anything in the browsing part of the app 🤔 |
Yes. First time I started the app it looked like this. Tried starting it a few more times, same thing. It is indeed weird. |
I forgot to merge the username fixes from master to the chat branch. Did that now but could not get it to work but did not have time to test it with userid set. If you are upp for it you can try the chat branch again. Oh does the 3.9.2 version work for you? Just trying to locate what I messed up :/ |
I think I found the problem, I had written |
Syntax error :) 3.9.2 working fine (20-30sec delay is still present when comapred to pc-chrome-twitch website). I will test it today when I get some time. |
I have just tried it. It works like regular no chat version of the app. So basically streams are loading but there is no chat. I looked for option somewhere (to enable/disable chat) and haven't seen one. Tried a few different streamers, same, no chat visible. |
The chat should show in the choose quality panel on the right. To show it press enter or left arrow. |
I checked there, only choose quality panel, no chat. Looks same just in regular 3.9.2 release. |
Okay, as long as enableChat is set to true in config.js then it should show if it works. The Tizien fork is using websockets and connecting to the irc channel directly. Will look at this and see if I can use the same implementation here. |
Thanks for trying. If you need help, let me know. |
The original creator tried to add chat years ago via iframe but said it lagged a lot because of flash. It might work much better now.
I think the fork for Tizien have chat so we can look and see if we can adapt it for this version.
Todo:
The text was updated successfully, but these errors were encountered: