Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strong_type instead of NamedType for ProgramId #309

Closed
Tracked by #257
PatrickKa opened this issue Jul 6, 2024 · 2 comments · Fixed by #312
Closed
Tracked by #257

Use strong_type instead of NamedType for ProgramId #309

PatrickKa opened this issue Jul 6, 2024 · 2 comments · Fixed by #312
Assignees
@Tomoya-Hagen
Labels
1 type: refactor 2 scope: firmware

Comments

@PatrickKa
Copy link
Contributor

Description

We replaced the NamedType library with strong_type (see SpaceTeam/STS1_COBC_Docker#58 for details) so we need to change ProgramId, our only strong type so far, accordingly. See #308 for an inspiration on how to use the strong_type library.
@PatrickKa
Copy link
Contributor Author

Blocked because while SpaceTeam/STS1_COBC_Docker#58 is already implemented, a new version of the Docker image is not yet released.

@PatrickKa PatrickKa mentioned this issue May 26, 2024
Open
5 tasks
@PatrickKa
Copy link
Contributor Author

Until the new version of the Docker image is released, we installed the library locally in our container to not be blocked by that.

@PatrickKa PatrickKa mentioned this issue Jul 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tomoya-Hagen Tomoya-Hagen

Labels
1 type: refactor 2 scope: firmware
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add strong types in FRAM code and refactor ProgramId SpaceTeam/STS1_COBC_SW
2 participants
@PatrickKa @Tomoya-Hagen