Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Encoding Selector? #126

Closed
NullPlane opened this issue Feb 9, 2024 · 4 comments
Closed

[FEATURE] Encoding Selector? #126

NullPlane opened this issue Feb 9, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request released

Comments

@NullPlane
Copy link

Did not find no encoding selectors and some documents with german symbols are broken so I'd have to toggle. Mostly there's no problems if you initially write these files in ecode but opening one from e.g. RAD Studio breaks all the german umlauts and renders the code to be all commented as some closing brackets vanish.

@SpartanJ SpartanJ self-assigned this Feb 9, 2024
@SpartanJ SpartanJ added the enhancement New feature or request label Feb 9, 2024
@SpartanJ
Copy link
Owner

SpartanJ commented Feb 9, 2024

Yes, this is a currently limitation given a design choice: the editor only supports UTF-8 encoding as for the moment. It's not hard to add support for more encoding, but would add some dependencies and I wanted to keep it simple. But as it gets bigger I'll have to at least support most common encodings.

@SpartanJ
Copy link
Owner

SpartanJ commented Feb 9, 2024

Can you share any file so I can check its encoding and maybe it's some of the easy cases.

@NullPlane
Copy link
Author

Well quite hard. I sadly lost the original I first had Problems with because I actually didn't look whether it was damaged and just saved it in its state... Idk if this still helps but here it is. I literally just changed something in the file's top section I cut away in this excerpt. Everything in there is just as I got it.

@SpartanJ
Copy link
Owner

Added support in the latest commits. For the moment we are going to support UTF-8, UTF-16 LE, UTF-16 BE and ISO-8859-1 (Latin1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

No branches or pull requests

2 participants