Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsaved mark exceeds tabwidth #287

Closed
NullPlane opened this issue Jun 30, 2024 · 6 comments
Closed

Unsaved mark exceeds tabwidth #287

NullPlane opened this issue Jun 30, 2024 · 6 comments
Assignees
Labels
bug Something isn't working ready for release

Comments

@NullPlane
Copy link

Idk how to classify this.
In short: If the filename is very long the * asterisk vanishes
to mark it unsaved.

@SpartanJ SpartanJ self-assigned this Jun 30, 2024
@SpartanJ SpartanJ added the bug Something isn't working label Jun 30, 2024
@SpartanJ
Copy link
Owner

SpartanJ commented Jun 30, 2024

Ohh, because the * goes at the end of the filename, so it gets cut, I didn't think about it when I added the ellipsis and never noticed. Let me think how to solve it. Maybe it's time to remove the asterisk all over.

@SpartanJ
Copy link
Owner

I removed the asterisk in favor of a visual color indicator:
Screenshot_20240630_203355

I think it looks better but it worries me a little if color blind people can perceive it (for me it's perfectly obvious but I'm not color blind).

I might add a circle like in vscode but I'm not convinced.

@SpartanJ
Copy link
Owner

Issue #69 is a request for a better distinction for saved and unsaved files, so this change is relevant for both issues.

@SpartanJ
Copy link
Owner

SpartanJ commented Jul 2, 2024

Mmh changed my mind, current version:
Screenshot_20240701_214746

@NullPlane
Copy link
Author

looks fresh.
What'll be the var in the ui styling?

@SpartanJ
Copy link
Owner

SpartanJ commented Jul 3, 2024

The UI can be styled with CSS as always. You can create a custom theme or use the --css command parameter. Here's the new CSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for release
Projects
None yet
Development

No branches or pull requests

2 participants