Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: By default it might be better to open terminal in vertical split or horizontal split than in a tab. #68

Closed
debajyoti1990 opened this issue Mar 4, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@debajyoti1990
Copy link

lapce editor for example does a very simple trick, ctrl+ opens terminal in hsplit and focuses on it. Hitting ctrl+ minimizes the terminal and so focus is back to editor now. I'm in windows so don't know MAC/Linux behavior.

@SpartanJ SpartanJ self-assigned this Mar 4, 2023
@SpartanJ SpartanJ added the enhancement New feature or request label Mar 4, 2023
@SpartanJ
Copy link
Owner

SpartanJ commented Mar 4, 2023

I generally create a terminal split too. There are keybindings for that already there:
I'm not sure about changing the default behavior, I find it a little confusing opening a split when not explicitly requested.
Screenshot_20230304_130621

Lapce takes a different approach than ecode. It's similar to most editors, the terminal area is separated from the document area, I think my approach is better, you can mix terminals and documents at will. But I'm open to suggestions regarding this topic.

@debajyoti1990
Copy link
Author

The highlighted keybinding are little hard to follow if used as a daily driver. Moreover I just used Lapce's example just as a reference. I think VScode / Pycharm / Kate all have similar default behaviour what I suggested. If terminal is opened in a hsplit/vsplit it becomes easy to follow the code and run/repl at the same time. That's just my opinion though. If default behavior can't be changed, a drag and drop to hsplit/vsplit should also be good if implementable at all.

@SpartanJ
Copy link
Owner

SpartanJ commented Mar 6, 2023

The behavior will be configurable from the settings menu:
new-terminal-behavior
The default configuration is the one visible on the screenshot.

@debajyoti1990
Copy link
Author

Thanks.

@debajyoti1990
Copy link
Author

Probably not worthy of a new issue, but, is there a way to setup same theme for file browser, terminal and editor?

@SpartanJ
Copy link
Owner

SpartanJ commented Mar 6, 2023

Those are separated components, the default theme for the three of them is the "same theme". I only ported a few themes for the editor and the terminal, they are really easy to port, but there's only one theme for the GUI (with dark and light versions). Currently, there are no alternatives, and changing the GUI theme isn't straightforward. I'll add an option to easily change the GUI theme, at least to override the colors, that's really easy actually (the theme is just a CSS file, and the colors are CSS variables). I want to provide the tools to easily customize the editor but I won't focus on adding themes and customizing the GUI, I think that's not a good use of my very limited time. And that's why I need collaborators =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants