Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] You're Right flips more than it should #39

Open
wont-stream opened this issue Sep 22, 2024 · 4 comments
Open

[Bug] You're Right flips more than it should #39

wont-stream opened this issue Sep 22, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@wont-stream
Copy link

wont-stream commented Sep 22, 2024

Describe the bug
The images inside of embeds are flipped
Flips stuff it shouldn't flip

To Reproduce

Expected behavior
Doesn't flip the image
Doesn't flip everything

Screenshots
{C7D4BEF3-BC67-432C-9258-1C7DE6C28327}
{6EF0DD7A-696D-4901-8355-7236146979CB}

System Info (please complete the following information):

  • OS: Windows 11
  • Discord version: Development
  • Any other relevant info: N/A

Additional context
N/A

@wont-stream wont-stream added the bug Something isn't working label Sep 22, 2024
@wont-stream
Copy link
Author

Adding transform: scaleX(-1); to the affected embed images makes it appear normally, but the additional styles would have to be done plugin side so it doesn't apply to every embed image, including non flipped ones.

@wont-stream
Copy link
Author

I take it back

[class*="_youreRightItem_"] img {
	transform: scaleX(-1);
}

seems to fix it

@wont-stream wont-stream changed the title [Bug] You're Right flips embed images [Bug] You're Right flips more than it should Sep 22, 2024
@wont-stream
Copy link
Author

Of course as I comment I find it affects invites as well
Updated CSS

[class*="_youreRightItem_"] img,
[class*="_youreRightItem_"] [type="button"] [class^="contents_"],
[class*="_youreRightItem_"] [class^="statusCounts_"] {
	transform: scaleX(-1);
}

Only somewhat fixes invites

{207767E6-97EC-47AB-BB78-E8F33481FD2B}

@wont-stream
Copy link
Author

Turns out [class*="_youreRightItem_"] img, flips non flipped images sent by the user as well..
Styling would better be done plugin side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant