-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added kraken 1.1.1 to roary 3.13.0 dockerfile #260
Conversation
I'm testing now. Will let you know if I run into issues. |
Roary worked okay, and kraken didn't throw any errors per se, but it also didn't work. It throws an error while trying to run kraken :
Even if I define I am unsure as to why this is, so I'll be looking into it next week-ish. |
Are you perhaps using a kraken2 database ? If so, I don't think that will be compatible with kraken v1 |
I want to look into that. I only got as far as trying kraken's 'minikraken_20141208' database with the same results. For whatever reason, the environmental variable I want to make sure that kraken itself works in the container - outside of roary. |
OK I was able to test out this container with 3 salmonella Hadar assemblies and got the optional kraken feature to run successfully. It seems that The following command worked. Fed in 3 .gff files into Roary Relevant bits of STDOUT:
Output kraken QC file
The above command produced all output |
I had some time today, and I can confirm that it works with kraken databases. My kraken database had been corrupted when I tested it prior. My apologies. First, I pulled the container with singularity
Then I ran it
And it worked!
I do have a concern, however, in that I used to use it with kraken2 databases, and I'm not sure how to add in that functionality. There doesn't seem to be any documentation about that, however. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me as well
Glad to hear it ran successfully!
Huh. I thought Roary pre-dated kraken2, so I didn't think there was support for it. Does that required kraken2 to be installed or can you use kraken1 with a kraken2 database? I was going to merge this PR and build on dockerhub since it's running properly with kraken1, but we can wait if you'd like to try it out with a kraken2 database. Let me know what you'd prefer! |
I think it's fine to merge it. I am confused as well. My notes have roary using the kraken2 database, but I can't seem to replicate those. I'm willing to move on with my life. |
agreed 😆 I'll merge and re-build the docker image on dhub and quay. Planning on re-building the Thanks for testing and I hope this is useful for you and others! |
To address #254
Docker image is available temporarily on dockerhub under my personal repo
kapsakcj/roary:3.13.0-plus-kraken
https://hub.docker.com/r/kapsakcj/roary/tags?page=1&ordering=last_updated
@erinyoung Can you try it out and let me know how it goes? Would appreciate a quick test (I don't have any data handy to do this), especially run via
singularity
.One thing to note is that I'm trying something new. I've set
LC_ALL=C.UTF-8
instead of the usualLC_ALL=C
. I've read that this will prevent headaches down the road. Something to do with encoding or something....If you have perl issues, we can revert back to LC_ALL=C before merging this PR and rebuilding the
staphb/roary:3.13.0
docker image