feat: add country code to geogate analytic #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lucasrmp-cb
commented
Jan 23, 2025
| @@ -23,7 +24,9 @@ export const GeoGate = (props: GeoGateProps) => { | |||
| const userCountryCode = Cookies.get(USER_COUNTRY_CODE_COOKIE_NAME) | |||
|
|
|||
| if (!isValidCountryCode({ countryCode, userCountryCode, bypassCountryCheck })) { | |||
| return unavailableContent | |||
| return React.cloneElement(unavailableContent as React.ReactElement<{ countryCode: string }>, { | |||
There was a problem hiding this comment.
Doing it this way to not need to always pass the country code to the fallback and also to not have to change the component signature
LucasdRossi
approved these changes
Jan 28, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1771
What changed? Why?
PlanetScale deploy request
Notes to reviewers
How has it been tested?