Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove magic numbers #5

Closed
motiwari opened this issue Aug 5, 2022 · 3 comments
Closed

Remove magic numbers #5

motiwari opened this issue Aug 5, 2022 · 3 comments
Assignees

Comments

@motiwari
Copy link

motiwari commented Aug 5, 2022

Magic numbers are an anti-pattern -- it makes code hard to read, and requires every instance for the magic number to be updated if it should be changed.. It's better to move these to a constants.py file and import them everywhere.

Examples

@d1ngn1gefe1
Copy link
Collaborator

These magic numbers mainly show up preproc. The preproc directory is only needed for data pre-processing and should be made internal/private.

@zanedurante @linden-li Shall we create a separate GitHub repo? Is there a better way of making some directories private.

@linden-li
Copy link
Collaborator

linden-li commented Aug 7, 2022

@zanedurante @linden-li Shall we create a separate GitHub repo? Is there a better way of making some directories private.

Yes, we can create a separate GitHub repo for data preparation and cleaning. We'll be releasing the cleaned annotations publicly anyway.

@linden-li
Copy link
Collaborator

@d1ngn1gefe1 Making this as done, since you made them private variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants