-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set "display: none" when height is 0 #16
Comments
Hello @apers, |
That was quick! |
@Stanko I think this functionality is breaking something else - it is causing animating from 0 to another value (using ResizeObserver) to not work. This is what's happening, if I understand correctly:
Could you please let us disable this feature or find another way to fix the tab focus issue without Here's a workaround I came up with:
|
@Stanko I'd also like to request that the I would like elements within zero-height containers to be able to receive focus, so that the user can tab to them and have the container be automatically expanded. I can also see where and why a developer would not want hidden elements to be focusable - both options are useful. Currently I am using a similar |
hey, it is a valid point. I'll try to add it today or during the weekend. |
I just published v3.2.3 with a new I added an additional check - when height is zero and there is no children elements, display: none won't be applied. Hope this helps, cheers! |
Would it be possible to set "display: none" when height is 0 so the content doesn't take tab focus when hidden?
The text was updated successfully, but these errors were encountered: