Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported Enhance power Control: Piloting upgrades mods generate errors. #1663

Closed
obrenckle opened this issue Aug 10, 2024 · 1 comment · Fixed by #1668
Closed

Imported Enhance power Control: Piloting upgrades mods generate errors. #1663

obrenckle opened this issue Aug 10, 2024 · 1 comment · Fixed by #1668
Labels
bug Something isn't working

Comments

@obrenckle
Copy link
Contributor

Describe the bug
After being imported from Oggdude's data, the modifiers from both Control: Piloting upgrades of the Enhance force power generates error when trying to alter them.
Deleting and recreating them fix the issue.

To Reproduce
Steps to reproduce the behavior:

  1. Import force powers from Oggdude
  2. Open "Enhance" force power from the compendium
  3. Click on the gear icon of one of the Control: Piloting ... upgrades to access modifiers
  4. Change "Skill boost" to "Skill force boost"
  5. See error: Attribute keys may not contain spaces or periods and in console TypeError: Cannot create property '-=Piloting: Space' on number '2' at PopoutModifiers._updateObject (popout-modifiers.js:96:67)
  6. Any modification except deleting the modifier isn't saved.

Expected behavior
The modifiers is changed and saved without error.

Screenshots
ForcePowerModifierError

Desktop (please complete the following information):

  • Foundry Version: 12.330
  • System Version mostly 1.902 with additional commits
  • Hosted on Forge: No
@obrenckle obrenckle added the bug Something isn't working label Aug 10, 2024
@obrenckle obrenckle reopened this Aug 11, 2024
@obrenckle
Copy link
Contributor Author

obrenckle commented Aug 11, 2024

The key set during import for the attribute containing the modifiers data use the skill name, i.e. system.upgrades.upgrade4.attributes["Piloting: Planetary"], while key created manual have a generic fomr attr+datetime, e.g. system.upgrades.upgrade8.attributes.attr1723360981032.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant