Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] - dayStartFrom and dayStop don't work on custom period #73

Closed
zomervinicius opened this issue Nov 30, 2018 · 2 comments
Closed

[Bug] - dayStartFrom and dayStop don't work on custom period #73

zomervinicius opened this issue Nov 30, 2018 · 2 comments

Comments

@zomervinicius
Copy link
Contributor

zomervinicius commented Nov 30, 2018 •
edited
Loading

This config set the day start to the hour I set,

And the day stop only to the last day of the period selected,

Not each day of the period,

Like the images below, that shows when I set dayStartFrom to 8 and dayStop to 18:

screenshot from 2018-11-28 16-50-21
screenshot from 2018-11-28 16-50-34
screenshot from 2018-11-28 16-50-26
@StephenChou1017
Copy link
Owner

@zomervinicius
Hi, I've fixed this issue and checked in the code just now:-)

@zomervinicius
Copy link
Contributor Author

Awesome, thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StephenChou1017 @zomervinicius