From b2cab65d51453c2cf83283560765d392356d762d Mon Sep 17 00:00:00 2001 From: SteveGilham Date: Sat, 20 Jul 2024 21:34:17 +0100 Subject: [PATCH] Make public some APIs that had been auto-internalized. Two more glitches to fix --- AltCover.Recorder/Recorder.cs | 10 +++--- rework failure list.txt | 64 +++++++++++------------------------ 2 files changed, 25 insertions(+), 49 deletions(-) diff --git a/AltCover.Recorder/Recorder.cs b/AltCover.Recorder/Recorder.cs index 97c1e90a..f8c8c0a9 100644 --- a/AltCover.Recorder/Recorder.cs +++ b/AltCover.Recorder/Recorder.cs @@ -26,13 +26,13 @@ public static class Instance /// Gets the location of coverage xml file /// This property's IL code is modified to store the actual file location /// - internal static string ReportFile + public static string ReportFile { [MethodImpl(MethodImplOptions.NoInlining)] get { return "Coverage.Default.xml"; } } - internal static string ReportFilePath + public static string ReportFilePath { get { @@ -53,7 +53,7 @@ internal static string CanonicalPath(string path) /// Gets whether to defer output until process exit /// This property's IL code is modified to store the actual value /// - internal static bool Defer + public static bool Defer { [MethodImpl(MethodImplOptions.NoInlining)] get { return false; } @@ -101,7 +101,7 @@ internal static Sampling Sample /// Gets the unique token for this Instance /// This property's IL code is modified to store a GUID-based token /// - internal static string Token + public static string Token { [MethodImpl(MethodImplOptions.NoInlining)] get { return "AltCover"; } @@ -892,7 +892,7 @@ public static void Pop() [SuppressMessage("Gendarme.Rules.Performance", "AvoidUncalledPrivateCodeRule", Justification = "Internals Visible To")] - internal static void FlushFinish() + public static void FlushFinish() { I.FlushAll(Close.ProcessExit); } diff --git a/rework failure list.txt b/rework failure list.txt index 66d35c53..7ecc9b04 100644 --- a/rework failure list.txt +++ b/rework failure list.txt @@ -1,39 +1,4 @@ -Issue72 00:00:08.1871717 ( - -(found, "first") = (["1"; "4"; "3"; "1"; "2"; "1"; "1"; "1"; "5"; "5"], "first") -(["0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"], "first") = (["1"; "4"; "3"; "1"; "2"; "1"; "1"; "1"; "5"; "5"], "first") -false -) - -DotnetTestIntegration 00:00:17.4145571 ( Bad visit list ["0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; - "0"; "0"; "0"; "0"] in C:\Users\email\Documents\Github\altcover\_DotnetTest\coverage.net8.0.xml -Assert.That(, ) - String lengths are both 39. Strings differ at index 2. - Expected: "0 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 2 1 1 1" - But was: "0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0" - -------------^ -) - -Cake2Test 00:00:43.1579842 ( Bad visit list ["0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; - "0"; "0"; "0"; "0"] in C:\Users\email\Documents\Github\altcover\_Cake\_DotnetTest\coverage.build.cake.--version 2.0.0.net8.0.xml -Assert.That(, ) - String lengths are both 39. Strings differ at index 2. - Expected: "0 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 2 1 1 1" - But was: "0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0" - -------------^ -) - - -ApiUse 00:00:15.8093949 ( Bad visit list ["0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; - "0"; "0"; "0"; "0"] in C:\Users\email\Documents\Github\altcover\_ApiUse\_DotnetTest\coverage.net8.0.xml -Assert.That(, ) - String lengths are both 39. Strings differ at index 2. - Expected: "0 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 2 1 1 1" - But was: "0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0" - -------------^ -) - -WindowsPowerShell +WindowsPowerShell, Pester missing methods Void AltCover.LCov.convertReport XDocument AltCover.Cobertura.convertReport @@ -41,12 +6,23 @@ Void AltCover.CoverageParameters.set_theReportFormat Void AltCover.PostProcess.action String AltCover.Json.xmlToJson -Pester - ditto - UnitTestWithAltCoverCoreRunner - Failed AltCoverMonitorTests.MonitorTests.ShouldRecordPointTotals [417 ms] - Error Message: - Object reference not set to an instance of an object. - Stack Trace: - at AltCover.Local.Monitor.TryGetPointTotals(PointCount& totals) in C:\Users\email\Documents\Github\altcover\AltCover.Monitor\Monitor.cs:line 161 - var xml = i.GetProperty("ReportFile").GetValue(null, Type.EmptyTypes).ToString(); + AltCover.Recorder -> C:\Users\email\Documents\Github\altcover\_Binaries\UnitTestWithCoreRunner_AltCover + .Recorder\Debug+AnyCPU\net46\AltCover.Recorder.dll +C:\Program Files\dotnet\sdk\8.0.303\FSharp\Microsoft.FSharp.Targets(332,9): error MSB6004: The specified +task executable location "C:\Program Files\dotnet\sdk\8.0.303\FSharp\fsc.exe" is invalid. [C:\Users\email +\Documents\Github\altcover\__AltCover.Recorder.Tests\AltCover.Recorder.Tests.fsproj::TargetFramework=net4 +72] +C:\Program Files\dotnet\sdk\8.0.303\FSharp\Microsoft.FSharp.Targets(332,9): error MSB6004: The specified +task executable location "C:\Program Files\dotnet\sdk\8.0.303\FSharp\fsc.exe" is invalid. [C:\Users\email +\Documents\Github\altcover\__AltCover.Recorder.Tests\AltCover.Recorder.Tests.fsproj::TargetFramework=net8 +.0] +Finished (Failed) 'ReplayUnitTestWithAltCoverCoreRunner' in 00:01:55.4040158 + + +Pester 00:00:00 (skipped) +Deployment 00:00:00 (skipped) +UnitTestWithAltCoverCoreRunner 00:00:00 (skipped) +UnitTest 00:00:00 (skipped) +BulkReport 00:00:00 (skipped) +All 00:00:00 (skipped)