New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve algorithm for getting transport info. #60

Open

F483 opened this issue Jan 4, 2016 · 1 comment

Assignees

Labels

Contributor

F483 commented Jan 4, 2016

Currently all peers in the local routing table are sent stun requests. This is not very efficient as we must wait for all answers.

Better would be to stun only one peer at a time until a result is found, but this requires some adaptation.
There should also be a check to filter results only from public nodes, to ensure the the transport info is correct.
Since the transport info is very unlikely to change, it should be cached once a correct result is found.

https://github.com/Storj/storjnode/blob/develop/storjnode/network/server.py#L247

F483 added the bug label

F483 self-assigned this

Contributor Author

F483 commented Jan 5, 2016

The impact of the current implementation is not noticeable so this is low priority for now.

F483 added enchancement and removed bug labels

super3 added optimization and removed enchancement labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment