Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that messages do not contain dicts #80

Open
F483 opened this issue Jan 15, 2016 · 0 comments
Open

Check that messages do not contain dicts #80

F483 opened this issue Jan 15, 2016 · 0 comments
Labels
ready security

Comments

@F483
Copy link
Contributor

F483 commented Jan 15, 2016

storjnode.network.messages.base.* used for messages signing/validation should check that the message body does not contain any dicts.

The reason being the order of dicts is not guaranteed and can thus break signing/validation.

https://github.com/Storj/storjnode/blob/develop/storjnode/network/messages/base.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@F483