-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incomplete basic output #403
Comments
I updated the example and did a little investigation. I think the issue is that RefValidator doesn't contain a custom implementation of apply, so any |
We can't use the json schema to redact the config anymore because annotations are not surfaced across schema refs: Stranger6667/jsonschema#403
Fix #5003 This reworks the json schema generation for the config so that it is reduced in size from approx 100k lines to jsut over 7k. The fix involves three things: * Enable references on json schema generation. This got disabled in the past because there were issues with the generated references, but by adding a schema visitor we can work around this. * Adjust the schema generation for Extendable and Conditional. These previously relied on the scheme not using references. * Modify orbiter metrics to redact only based on the properties in the schema rather than on validation metadata as this is not possible when using schema refs: Incomplete basic output Stranger6667/jsonschema#403
Fix #5003 This reworks the json schema generation for the config so that it is reduced in size from approx 100k lines to jsut over 7k. The fix involves three things: * Enable references on json schema generation. This got disabled in the past because there were issues with the generated references, but by adding a schema visitor we can work around this. * Adjust the schema generation for Extendable and Conditional. These previously relied on the scheme not using references. * Modify orbiter metrics to redact only based on the properties in the schema rather than on validation metadata as this is not possible when using schema refs: Incomplete basic output Stranger6667/jsonschema#403
Sorry for the delay, with the current approach, it is a bit complicated as annotations are bound to the schema. Not sure if it would be possible to keep the references, but maybe making annotations own their data would be a better way to go anyway. |
Fixed! However, keyword paths are incorrect in many cases. I am going to fix them separately |
When creating basic output sometimes the results look incomplete. For example:
Output:
Expected output:
The text was updated successfully, but these errors were encountered: