Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Add form does not enable the Create New button #691

Open
mingfang opened this issue Jan 17, 2015 · 4 comments
Open

Manual Add form does not enable the Create New button #691

mingfang opened this issue Jan 17, 2015 · 4 comments
Labels

Comments

@mingfang
Copy link

I'm trying to add a github project using the Manual Add form.
In the form I fill in these values
Display Url: https://github.com/Strider-CD/strider
Name: Strider-CD/strider
Url: https://github.com/Strider-CD/strider.git

But the Create New button remains disabled and not clickable.
I'm running v1.6.0 inside Docker https://github.com/mingfang/docker-stridercd
Also, other projects using my github account works fine; Just having problem with Manual Add

@fernandoneto
Copy link

in the url you must use ssh address of your repo.
make the test and worked for me

@mingfang
Copy link
Author

So I was able to get it to work by first selecting Http but didn't fill in the authentication info.
The Create New button got enabled and I was able to add and build the project.
The prepare stage says this
git clone --recursive http://[username]:[password]@github.com/Strider-CD/strider.git
Which is a result of not adding any authentication info. I'm surprise that works at all.
Anyway it works, just not very user friendly.

@kfatehi
Copy link
Member

kfatehi commented Jan 18, 2015

Thanks @mingfang -- we'll leave this open for investigation later -- we definitely want it to be user friendly / intuitive. If you can think of a specific way to improve the behavior of the form, your contribution is very welcome.

@kfatehi kfatehi reopened this Jan 18, 2015
@knownasilya knownasilya added this to the v1.6.5 milestone Feb 18, 2015
@knownasilya knownasilya modified the milestones: v1.6.5, v1.7.0 Mar 27, 2015
@knownasilya
Copy link
Member

@mingfang it says git clone --recursive http://[username]:[password]@github.com/Strider-CD/strider.git because that is the "safe" version of the url, i.e. it doesn't expose the credentials. IT will show that even if you didn't put any credentials in.

@knownasilya knownasilya removed this from the v1.8.0 milestone Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants