Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: nuget.pkg.github.com subdomain support #973

Closed
umaim opened this issue Aug 4, 2019 · 4 comments
Closed

Feature Request: nuget.pkg.github.com subdomain support #973

umaim opened this issue Aug 4, 2019 · 4 comments
Labels
invalid ⛔ This doesn't seem right

Comments

@umaim
Copy link

umaim commented Aug 4, 2019

For example: https://nuget.pkg.github.com/StylishThemes/GitHub-Dark

@the-j0k3r
Copy link
Member

the-j0k3r commented Aug 4, 2019

I would say please make your request known in #938

This would work as an addition to the regex @-moz-document regexp("^https?://((nuget\\.pkg|gist|guides|help|launch-editor|raw|resources|status|developer)\\.)?github\\.com/((?!generated_pages/preview).)*$")

@xt0rted
Copy link
Member

xt0rted commented Aug 4, 2019

I don't think you're actually supposed to browse the site from this subdomain. By default you're not even logged in to it. It's my understanding that this is meant to be used by package managers only. Is there anything available under *.pkg.github.com that isn't accessible from github.com?

@umaim
Copy link
Author

umaim commented Aug 4, 2019

Hahaha, yep, I accidentally opened this subdomain, and I do not work on it in daily work. And I didn't find any difference between it and main site, it looks like a mirror. :/

If you consider it not necessary to be supported by GItHub Dark, it's fine, haha. :)

@the-j0k3r
Copy link
Member

the-j0k3r commented Aug 4, 2019

Yep seems like it https://nuget.pkg.github.com/ will display
Screenshot from 2019-08-04 20-26-13

So not really something that needs supporting I would say, Hence closing, though if anyone feels differently feel free to re-open.

@the-j0k3r the-j0k3r added invalid ⛔ This doesn't seem right and removed enhancement ⭐ New feature or request labels Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid ⛔ This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants