Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] iframe support via WebViews on Flutter for Web #873

Closed
erickok opened this issue Oct 21, 2021 · 3 comments
Closed

[FEATURE] iframe support via WebViews on Flutter for Web #873

erickok opened this issue Oct 21, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@erickok
Copy link
Collaborator

erickok commented Oct 21, 2021

Describe your feature request

We use flutter_webview to render iframes, but this only support Flutter for Android and iOS. On Flutter for Web this does nothing - iframes are not rendered.

However, we are so close to full Flutter for Web support that having support for iframe rendering would be nice.
Additional context

It first seemed unfeasible and out of scope, but I found this post explaining how we can actually render html trees in Flutter Web: https://stackoverflow.com/questions/58150503/webview-in-flutter-web

This is actually directly supported by the flutter_webview alternative package https://pub.dev/packages/easy_web_view/changelog

A picture of a cute animal (not mandatory but encouraged)

@erickok erickok added the enhancement New feature or request label Oct 21, 2021
@tneotia
Copy link
Collaborator

tneotia commented Oct 23, 2021

I thought I coded this in? Maybe I remember wrong but it should be very easy to implement this if it isn't already.

@erickok
Copy link
Collaborator Author

erickok commented Oct 25, 2021

I think you are right! https://github.com/Sub6Resources/flutter_html/blob/master/lib/src/widgets/iframe_web.dart

I will test this and if it works close this ticket. Also good to know wrt #875 as we supoort more already on web than I though we did.

@erickok
Copy link
Collaborator Author

erickok commented Nov 29, 2021

Fixed in 2.2.0 release which has explicitly defined web support.

@erickok erickok closed this as completed Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants