Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disc support in the track list #188

Closed
skyline75489 opened this issue Jan 22, 2024 · 6 comments
Closed

Disc support in the track list #188

skyline75489 opened this issue Jan 22, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@skyline75489
Copy link

Describe the bug

Tracks from different discs are incorrectly organized in the track list.

To Reproduce

截屏2024-01-22 15 26 47

Note how the track with No.1 is grouped together. They're from different discs

Expected behavior

截屏2024-01-22 15 27 11

Screenshots
If applicable, add screenshots to help explain your problem.

Versions:

  • macOS: 14.0
  • Subsonic Server and Version: Navidrome 0.52
  • Submariner Version: 3.0
  • Download Source: GitHub Release

Additional context
Add any other context about the problem here.

@skyline75489 skyline75489 added the bug Something isn't working label Jan 22, 2024
@NattyNarwhal
Copy link
Member

Odd, the default sort order should be disc-then-track; there's a method assigned to the table's delegate that should also force that sort order if you click the disc number column. If that doesn't work, I'd wondered why. I'm also using Navidrome, so it should understand disc numbers coming back from responses. too.

FWIW, there is the "use more violence approach" - the table sort descriptors seem to be saved in default keys prefixed with NSTableView Sort Ordering v2.

@skyline75489
Copy link
Author

Yeah...clicking the dis number column fixes the order, and the wrong order is gone forever.

@NattyNarwhal
Copy link
Member

Good to know that fixes it, though it's a little strange that it got that way in the first place. Do you remember anything that happened that might have changed the sort order?

@skyline75489
Copy link
Author

Nothing really. I just launch the app the first thing I see is the wrong order in the screenshot.

@NattyNarwhal
Copy link
Member

Strange. I'll close this since it's been fixed. If you can reproduce it, please reopen it and let me know.

@blindmanonacid
Copy link

Hi, just want to mention that on a fresh install the tracks are still not organized by disc number. After searching the issue I came upon this report and clicking the number column have solved it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants